Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI styles for query assist #1523

Merged
merged 8 commits into from
Mar 15, 2024

Conversation

joshuali925
Copy link
Member

Description

  • styling change to query assist
    • move NLQ input above query textarea
    • wrap component in collapsible accordion
    • merge Generate query and Generate and run into a split button
    • update wording
  • guardrail support: display error callout if guardrail is triggered

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 56.97%. Comparing base (d17cad3) to head (dcb9247).
Report is 2 commits behind head on main.

Files Patch % Lines
...ts/event_analytics/explorer/query_assist/input.tsx 56.06% 27 Missing and 2 partials ⚠️
public/components/common/search/query_area.tsx 0.00% 8 Missing ⚠️
...components/event_analytics/explorer/no_results.tsx 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1523      +/-   ##
==========================================
+ Coverage   56.62%   56.97%   +0.34%     
==========================================
  Files         348      348              
  Lines       12656    12748      +92     
  Branches     3202     3294      +92     
==========================================
+ Hits         7167     7263      +96     
+ Misses       5436     5429       -7     
- Partials       53       56       +3     
Flag Coverage Δ
dashboards-observability 56.97% <54.54%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulstn paulstn merged commit 9a4e532 into opensearch-project:main Mar 15, 2024
13 of 20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 15, 2024
* update ui for query assist

Signed-off-by: Joshua Li <[email protected]>

* mock prohibited query when generating ppl

Signed-off-by: Joshua Li <[email protected]>

* update tests

Signed-off-by: Joshua Li <[email protected]>

* move guardrails check to server side

Signed-off-by: Joshua Li <[email protected]>

* focus input when selecting from suggestion

Signed-off-by: Joshua Li <[email protected]>

* update styles of run buttons

Signed-off-by: Joshua Li <[email protected]>

* hide patterns table by default

Signed-off-by: Joshua Li <[email protected]>

* show loading state for ppl generation

Signed-off-by: Joshua Li <[email protected]>

---------

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 9a4e532)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
paulstn pushed a commit to paulstn/dashboards-observability that referenced this pull request Mar 15, 2024
* update ui for query assist

Signed-off-by: Joshua Li <[email protected]>

* mock prohibited query when generating ppl

Signed-off-by: Joshua Li <[email protected]>

* update tests

Signed-off-by: Joshua Li <[email protected]>

* move guardrails check to server side

Signed-off-by: Joshua Li <[email protected]>

* focus input when selecting from suggestion

Signed-off-by: Joshua Li <[email protected]>

* update styles of run buttons

Signed-off-by: Joshua Li <[email protected]>

* hide patterns table by default

Signed-off-by: Joshua Li <[email protected]>

* show loading state for ppl generation

Signed-off-by: Joshua Li <[email protected]>

---------

Signed-off-by: Joshua Li <[email protected]>
ps48 pushed a commit that referenced this pull request Mar 15, 2024
* update ui for query assist



* mock prohibited query when generating ppl



* update tests



* move guardrails check to server side



* focus input when selecting from suggestion



* update styles of run buttons



* hide patterns table by default



* show loading state for ppl generation



---------


(cherry picked from commit 9a4e532)

Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@sejli sejli mentioned this pull request Mar 26, 2024
6 tasks
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…ch-project#1538)

* update ui for query assist

* mock prohibited query when generating ppl

* update tests

* move guardrails check to server side

* focus input when selecting from suggestion

* update styles of run buttons

* hide patterns table by default

* show loading state for ppl generation

---------

(cherry picked from commit 9a4e532)

Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 0d770f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants