-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UI styles for query assist #1523
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
joshuali925
requested review from
ps48,
kavithacm,
derek-ho,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
March 12, 2024 21:24
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1523 +/- ##
==========================================
+ Coverage 56.62% 56.97% +0.34%
==========================================
Files 348 348
Lines 12656 12748 +92
Branches 3202 3294 +92
==========================================
+ Hits 7167 7263 +96
+ Misses 5436 5429 -7
- Partials 53 56 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
ps48
approved these changes
Mar 14, 2024
ps48
approved these changes
Mar 14, 2024
paulstn
reviewed
Mar 15, 2024
paulstn
approved these changes
Mar 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
* update ui for query assist Signed-off-by: Joshua Li <[email protected]> * mock prohibited query when generating ppl Signed-off-by: Joshua Li <[email protected]> * update tests Signed-off-by: Joshua Li <[email protected]> * move guardrails check to server side Signed-off-by: Joshua Li <[email protected]> * focus input when selecting from suggestion Signed-off-by: Joshua Li <[email protected]> * update styles of run buttons Signed-off-by: Joshua Li <[email protected]> * hide patterns table by default Signed-off-by: Joshua Li <[email protected]> * show loading state for ppl generation Signed-off-by: Joshua Li <[email protected]> --------- Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 9a4e532) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
YANG-DB
approved these changes
Mar 15, 2024
paulstn
pushed a commit
to paulstn/dashboards-observability
that referenced
this pull request
Mar 15, 2024
* update ui for query assist Signed-off-by: Joshua Li <[email protected]> * mock prohibited query when generating ppl Signed-off-by: Joshua Li <[email protected]> * update tests Signed-off-by: Joshua Li <[email protected]> * move guardrails check to server side Signed-off-by: Joshua Li <[email protected]> * focus input when selecting from suggestion Signed-off-by: Joshua Li <[email protected]> * update styles of run buttons Signed-off-by: Joshua Li <[email protected]> * hide patterns table by default Signed-off-by: Joshua Li <[email protected]> * show loading state for ppl generation Signed-off-by: Joshua Li <[email protected]> --------- Signed-off-by: Joshua Li <[email protected]>
ps48
pushed a commit
that referenced
this pull request
Mar 15, 2024
* update ui for query assist * mock prohibited query when generating ppl * update tests * move guardrails check to server side * focus input when selecting from suggestion * update styles of run buttons * hide patterns table by default * show loading state for ppl generation --------- (cherry picked from commit 9a4e532) Signed-off-by: Joshua Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…ch-project#1538) * update ui for query assist * mock prohibited query when generating ppl * update tests * move guardrails check to server side * focus input when selecting from suggestion * update styles of run buttons * hide patterns table by default * show loading state for ppl generation --------- (cherry picked from commit 9a4e532) Signed-off-by: Joshua Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 0d770f7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generate query
andGenerate and run
into a split buttonIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.