Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sql direct query visualizations #1524

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joshuali925
Copy link
Member

Description

  • Add regex as a temporary solution to parse sql
  • Serialize and unserialize sql visualization in saved object
  • Hide configuration panel if not using default datasource

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.00%. Comparing base (d17cad3) to head (6ff99af).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1524      +/-   ##
==========================================
+ Coverage   56.62%   57.00%   +0.37%     
==========================================
  Files         348      349       +1     
  Lines       12656    12691      +35     
  Branches     3202     3210       +8     
==========================================
+ Hits         7167     7234      +67     
+ Misses       5436     5404      -32     
  Partials       53       53              
Flag Coverage Δ
dashboards-observability 57.00% <100.00%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants