-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace Analytics support for custom sources #2112
Conversation
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 2e052f2)
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit d832ea1)
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
includeMetricsCallback(); | ||
} | ||
} | ||
// console.log('value[0].id', value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed deleting console log comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Signed-off-by: Shenoy Pratik <[email protected]>
@TackAdam @RyanL1997 Thanks for the review.
|
Signed-off-by: Shenoy Pratik <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2112 +/- ##
==========================================
- Coverage 57.85% 56.59% -1.26%
==========================================
Files 372 389 +17
Lines 14081 14938 +857
Branches 3712 4049 +337
==========================================
+ Hits 8146 8454 +308
- Misses 5871 6422 +551
+ Partials 64 62 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-2112-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ec67ad1ce6a6d20c0e316a09488d907161931472
# Push it to GitHub
git push --set-upstream origin backport/backport-2112-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.17
# Create a new branch
git switch --create backport/backport-2112-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ec67ad1ce6a6d20c0e316a09488d907161931472
# Push it to GitHub
git push --set-upstream origin backport/backport-2112-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.17 Then, create a pull request where the |
* improve traces table Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 2e052f2) * improve queries Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit d832ea1) * add support for custom trace indices Signed-off-by: Shenoy Pratik <[email protected]> * update mode picker Signed-off-by: Shenoy Pratik <[email protected]> * added services view for custom trace source Signed-off-by: Shenoy Pratik <[email protected]> * updated snapshots Signed-off-by: Shenoy Pratik <[email protected]> * update DSL filter tests Signed-off-by: Shenoy Pratik <[email protected]> * update app analytics snapshots Signed-off-by: Shenoy Pratik <[email protected]> * remove console.log Signed-off-by: Shenoy Pratik <[email protected]> * update service map inputs, remove commented code Signed-off-by: Shenoy Pratik <[email protected]> * remove console.log, update copy and tests Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Joshua Li <[email protected]> (cherry picked from commit ec67ad1)
) * Trace Analytics support for custom sources (#2112) * improve traces table Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 2e052f2) * improve queries Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit d832ea1) * add support for custom trace indices Signed-off-by: Shenoy Pratik <[email protected]> * update mode picker Signed-off-by: Shenoy Pratik <[email protected]> * added services view for custom trace source Signed-off-by: Shenoy Pratik <[email protected]> * updated snapshots Signed-off-by: Shenoy Pratik <[email protected]> * update DSL filter tests Signed-off-by: Shenoy Pratik <[email protected]> * update app analytics snapshots Signed-off-by: Shenoy Pratik <[email protected]> * remove console.log Signed-off-by: Shenoy Pratik <[email protected]> * update service map inputs, remove commented code Signed-off-by: Shenoy Pratik <[email protected]> * remove console.log, update copy and tests Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Joshua Li <[email protected]> (cherry picked from commit ec67ad1) * update snapshots Signed-off-by: Shenoy Pratik <[email protected]> * update snapshots from upstream changes Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]>
…2117) * fix badge size for counters, change notebook delete, update test (#2110) (#2114) (cherry picked from commit 1c6ff11) Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]> * Trace Analytics support for custom sources (#2112) * improve traces table Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 2e052f2) * improve queries Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit d832ea1) * add support for custom trace indices Signed-off-by: Shenoy Pratik <[email protected]> * update mode picker Signed-off-by: Shenoy Pratik <[email protected]> * added services view for custom trace source Signed-off-by: Shenoy Pratik <[email protected]> * updated snapshots Signed-off-by: Shenoy Pratik <[email protected]> * update DSL filter tests Signed-off-by: Shenoy Pratik <[email protected]> * update app analytics snapshots Signed-off-by: Shenoy Pratik <[email protected]> * remove console.log Signed-off-by: Shenoy Pratik <[email protected]> * update service map inputs, remove commented code Signed-off-by: Shenoy Pratik <[email protected]> * remove console.log, update copy and tests Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Joshua Li <[email protected]> (cherry picked from commit ec67ad1) * update snapshots Signed-off-by: Shenoy Pratik <[email protected]> * update snapshots from upstream changes Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]>
Description
Experimental feature for Trace Analytics support of custom sources
Issues Resolved
#2052
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.