[Bug] Services Data Picker, UI Fixes #2177
Conversation
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
There was a problem hiding this comment.
When data source is disabled.
#data_source.enabled: false
Hi @TackAdam, If im understanding this correct, we are still relying on dataSource management's registration for checking the MDS feature flag status. Lets change the check from datasource management check into dataSource plugin, since the MDS status is not coming from data source management plugin's registration anymore.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2177 +/- ##
==========================================
- Coverage 56.58% 56.24% -0.35%
==========================================
Files 389 390 +1
Lines 14954 15083 +129
Branches 4059 4111 +52
==========================================
+ Hits 8462 8483 +21
- Misses 6430 6538 +108
Partials 62 62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
| export const observabilityTracesNewNavURL = observabilityTracesNewNavID; | ||
| export const observabilityTracesID = 'observability-traces'; | ||
| export const observabilityTracesTitle = 'Traces'; | ||
| export const observabilityTracesPluginOrder = 5093; | ||
|
|
||
| export const observabilityServicesNewNavID = 'observability-services-nav'; | ||
| export const observabilityServicesNewNavURL = observabilityServicesNewNavID + '#/services'; | ||
| export const observabilityServicesNewNavURL = observabilityServicesNewNavID; |
There was a problem hiding this comment.
If we are assigning the observabilityTracesNewNavURL = observabilityTracesNewNavID; Can we just use the observabilityTracesNewNavID directly?
There was a problem hiding this comment.
nit. Not sure why we have ID capitalized should be Id for at all places.
There was a problem hiding this comment.
Removed the NewNavURL variables.
Looks like all ID's are in this file Ill do a separate PR to fix as it will affect a lot of files and don't want the other changes to get overshadowed by it.
public/components/trace_analytics/components/common/__tests__/legacy_route_helpers.test.tsx
Show resolved
Hide resolved
public/components/trace_analytics/components/services/service_view.tsx
Outdated
Show resolved
Hide resolved
public/components/trace_analytics/components/services/service_view.tsx
Outdated
Show resolved
Hide resolved
| if (hash.includes('#/services/')) { | ||
| const serviceId = location.hash.split('/services/')[1]?.split('?')[0] || ''; | ||
| if (serviceId) { | ||
| if (isNewNavEnabled) { | ||
| window.location.assign( | ||
| `/app/${observabilityServicesNewNavID}#/services?datasourceId=&serviceId=${encodeURIComponent( | ||
| serviceId | ||
| )}` | ||
| ); | ||
| } else { | ||
| window.location.assign( | ||
| `/app/${observabilityTracesID}#/services?datasourceId=&serviceId=${encodeURIComponent( | ||
| serviceId | ||
| )}` | ||
| ); | ||
| } | ||
| return; | ||
| } | ||
| } |
There was a problem hiding this comment.
URL query parameters are not ordered by default. Browsers, servers, and other systems generally treat query parameters as unordered key-value pairs.
https://example.com/page?param1=value1¶m2=value2
https://example.com/page?param2=value2¶m1=value1
Will this work with and without serviceID being the first param?
There was a problem hiding this comment.
This check is for if a id is provided. The new navigation check is to handle the different urls used for both
observabilityServicesNewNavID vrs observabilityTracesID
This isn't affected by if MDS is enabled, as the legacy re-direction should only be for local host id's.
Signed-off-by: Adam Tackett <[email protected]>
* bug fix services data picker, ui fixes Signed-off-by: Adam Tackett <[email protected]> * add tooltip to the re-direct Signed-off-by: Adam Tackett <[email protected]> * fix services view page revert Signed-off-by: Adam Tackett <[email protected]> * fix services view page revert Signed-off-by: Adam Tackett <[email protected]> * fix services view Signed-off-by: Adam Tackett <[email protected]> * applied comments Signed-off-by: Adam Tackett <[email protected]> * fix traces bug Signed-off-by: Adam Tackett <[email protected]> * Fix bugs and add url redirection and testing Signed-off-by: Adam Tackett <[email protected]> * remove comment Signed-off-by: Adam Tackett <[email protected]> * address comments Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Adam Tackett <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> (cherry picked from commit cf01e52) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [Bug] Services Data Picker, UI Fixes (#2177) * bug fix services data picker, ui fixes Signed-off-by: Adam Tackett <[email protected]> * add tooltip to the re-direct Signed-off-by: Adam Tackett <[email protected]> * fix services view page revert Signed-off-by: Adam Tackett <[email protected]> * fix services view page revert Signed-off-by: Adam Tackett <[email protected]> * fix services view Signed-off-by: Adam Tackett <[email protected]> * applied comments Signed-off-by: Adam Tackett <[email protected]> * fix traces bug Signed-off-by: Adam Tackett <[email protected]> * Fix bugs and add url redirection and testing Signed-off-by: Adam Tackett <[email protected]> * remove comment Signed-off-by: Adam Tackett <[email protected]> * address comments Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Adam Tackett <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> (cherry picked from commit cf01e52) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update integ snapshot Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]>
Description
Bugfix:
Screen.Recording.2024-09-19.at.8.45.21.PM.mov
Metrics page after:
Before:
Overview page after:
Before:
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.