[Bug fix] Metrics datasource #2242
Conversation
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
| @@ -95,6 +97,11 @@ export const Sidebar = ({ | |||
| }, [selectedMetrics, selectedMetricsIds, dataSourceMDSId]); | |||
|
|
|||
| useEffect(() => { | |||
| // If data source is enabled but is still null prevent the invalid call | |||
| if (dataSourceEnabled && dataSourceMDSId === null) { | |||
There was a problem hiding this comment.
if local cluster is selected, what would dataSourceMDSId be?
There was a problem hiding this comment.
Local cluster is just an empty string "" when selected it get sets and is no longer null
| @@ -77,7 +77,7 @@ export const Home = ({ | |||
| const dispatch = useDispatch(); | |||
|
|
|||
| const onSelectedDataSource = async (dataSources: DataSourceOption[]) => { | |||
| const id = dataSources[0] ? dataSources[0].id : ''; | |||
| const id = dataSources[0] ? dataSources[0].id : null; | |||
There was a problem hiding this comment.
Only one question: What's the condition when dataSources[0] will be undefined and we have to set the id as null?
There was a problem hiding this comment.
The only condition this should be triggered is when a workspace is created and its datasource is removed putting it in a state where it has no data sources available at all. In this case metrics won't work and we don't want to display options.
We should probably have an empty state for this such as " No connected data source with redirection to associate one".
* set default datasource to null and prevent rendering until it is set Signed-off-by: Adam Tackett <[email protected]> * prevent invalid api call Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit 397a867) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* set default datasource to null and prevent rendering until it is set * prevent invalid api call --------- (cherry picked from commit 397a867) Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]>
Description
While datasource is enabled, set initial condition to null and wait to render page until the selection/default is registered.
Currently if a localhost is not defined the call will trigger the search on a non valid datasource.
This change prevents the search call from being triggered until the datasource has been read.
MetricsSearch.mov
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.