Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace index mapping with field caps API for trace filters #2246

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Nov 6, 2024

Description

Replace index mapping with field capabilties API for trace filters

Issues Resolved

  1. Fetch field with index mappings wasn't on-boarded to MDS which was leading to 500 connection errors
  2. Fields capabilities API now also works with CCS indices.
traces-ccs.mov

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ps48 ps48 added bug Something isn't working backport 2.x mds-2.18.0 labels Nov 6, 2024
@ps48 ps48 merged commit 6a43f53 into opensearch-project:main Nov 7, 2024
16 of 24 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 7, 2024
* Replace fetch fields with field capabilties for trace filters

Signed-off-by: Shenoy Pratik <[email protected]>

* add test updates, fix mdsId

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 6a43f53)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Nov 7, 2024
…2250)

* Replace fetch fields with field capabilties for trace filters



* add test updates, fix mdsId



---------


(cherry picked from commit 6a43f53)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x bug Something isn't working mds-2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants