Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add eslint workflow #320

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

RyanL1997
Copy link
Contributor

Description

[Backport 2.x] Add eslint workflow

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

RyanL1997 and others added 2 commits January 19, 2024 10:25
* Add eslint workflow

Signed-off-by: Ryan Liang <[email protected]>

* Correct the plugin name

Signed-off-by: Ryan Liang <[email protected]>

* Correct the plugin name2

Signed-off-by: Ryan Liang <[email protected]>

* change the linting running dir

Signed-off-by: Ryan Liang <[email protected]>

* Fix some comments

Signed-off-by: Ryan Liang <[email protected]>

* Add stylelint back

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bcec0d5) 94.73% compared to head (859ec2f) 94.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x     #320   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files           5        5           
  Lines         152      152           
  Branches       45       45           
=======================================
  Hits          144      144           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RyanL1997 RyanL1997 marked this pull request as ready for review January 19, 2024 19:55
@joshuali925 joshuali925 merged commit 2a756cf into opensearch-project:2.x Jan 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants