Exclude keys #3055
Merged
Exclude keys #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kat Shen <[email protected]>
Signed-off-by: Kat Shen <[email protected]>
Signed-off-by: Kat Shen <[email protected]>
Signed-off-by: Kat Shen <[email protected]>
Signed-off-by: Kat Shen <[email protected]>
Signed-off-by: Kat Shen <[email protected]>
shenkw1
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
Signed-off-by: Kat Shen <[email protected]>
Signed-off-by: Kat Shen <[email protected]>
chenqi0805
reviewed
Jul 25, 2023
...r/src/main/java/org/opensearch/dataprepper/plugins/processor/keyvalue/KeyValueProcessor.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/opensearch/dataprepper/plugins/processor/keyvalue/KeyValueProcessor.java
Outdated
Show resolved
Hide resolved
.../test/java/org/opensearch/dataprepper/plugins/processor/keyvalue/KeyValueProcessorTests.java
Show resolved
Hide resolved
…est, modify include/exclude null test to default test Signed-off-by: Kat Shen <[email protected]>
chenqi0805
reviewed
Jul 26, 2023
...r/src/main/java/org/opensearch/dataprepper/plugins/processor/keyvalue/KeyValueProcessor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kat Shen <[email protected]>
chenqi0805
reviewed
Jul 26, 2023
...r/src/main/java/org/opensearch/dataprepper/plugins/processor/keyvalue/KeyValueProcessor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kat Shen <[email protected]>
chenqi0805
previously approved these changes
Jul 26, 2023
...r/src/main/java/org/opensearch/dataprepper/plugins/processor/keyvalue/KeyValueProcessor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kat Shen <[email protected]>
chenqi0805
approved these changes
Jul 26, 2023
JonahCalvo
approved these changes
Jul 27, 2023
| @@ -153,6 +155,14 @@ private boolean validateRegex(final String pattern) | |||
| return true; | |||
| } | |||
|
|
|||
| private void validateKeySets(final Set<String> includeSet, final Set<String> excludeSet) { | |||
| Set<String> intersectionSet = new HashSet<String>(includeSet); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow configuration for an array specifying the parsed keys which should not be added to the event. By default no keys will be excluded
Issues Resolved
#890
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.