Moves the S3 sink and HTTP sink into their own packages. #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed and
oeyh
as code owners
dlvenable
force-pushed
the
unique-sink-packages
branch
from
a6f2b9b
to
ad24134
Compare
kkondaka
previously approved these changes
Jul 26, 2023
chenqi0805
previously approved these changes
Jul 27, 2023
…n issue where there are class conflicts at runtime. Signed-off-by: David Venable <[email protected]>
dlvenable
force-pushed
the
unique-sink-packages
branch
from
ad24134
to
3d15a3a
Compare
asifsmohammed
approved these changes
Jul 27, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running Data Prepper with the
s3sink resulted in class conflicts. This PR fixes these by moving the classes in thes3sink andhttpsink into their own packages.Issues Resolved
N/A
Does not affect a released version - only the
mainbranch.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.