ENH: support index template for serverless #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Chen <[email protected]>
chenqi0805
requested review from
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
dlvenable
requested changes
Aug 1, 2023
| final String enabled = getISMEnabled(response); | ||
| return enabled != null && enabled.equals("true"); | ||
| } catch (OpenSearchException ex) { | ||
| if (NON_RETRYABLE_HTTP_STATUS.contains(ex.status())) { |
There was a problem hiding this comment.
Should we have a stronger check here? This has any non-retryable indicating the ISM is disabled. What if the user lacks access? We might want that error to halt the sink.
...main/java/org/opensearch/dataprepper/plugins/sink/opensearch/index/AbstractIndexManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
dlvenable
approved these changes
Aug 10, 2023
|
We can ignore the WhiteSource checks. This PR does not change our dependencies. Likely it is failing because of the age of the PR and the branch. |
graytaylor0
approved these changes
Oct 9, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-3071-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b35ffc28f5999300f956090a86e51d06842fb3d2
# Push it to GitHub
git push --set-upstream origin backport/backport-3071-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5Then, create a pull request where the |
engechas
pushed a commit
to engechas/data-prepper
that referenced
this pull request
Oct 9, 2023
* ENH: support index template for serverless Signed-off-by: George Chen <[email protected]>
chenqi0805
added a commit
to chenqi0805/data-prepper
that referenced
this pull request
Oct 9, 2023
* ENH: support index template for serverless Signed-off-by: George Chen <[email protected]> (cherry picked from commit 73a80a1)
chenqi0805
added a commit
that referenced
this pull request
Oct 10, 2023
* ENH: support index template for serverless Signed-off-by: George Chen <[email protected]> (cherry picked from commit 73a80a1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resurrects support for composable index template for opensearch sink serverless ingestion. Thus allowing user to configure
index_type: customunderserverless: true.Note: Amazon OpenSearch Serverless does not support ISM policy plugin as well as the /_cluster/settings API. Thus the fix on
checkISMEnabled.Issues Resolved
#3048
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.