GitHub-issue#253 : Implemented download maxmind test mmdb files to re… #3193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…source folder Signed-off-by: venkataraopasyavula <[email protected]>
venkataraopasyavula
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
…source folder Signed-off-by: venkataraopasyavula <[email protected]>
dlvenable
requested changes
Aug 22, 2023
| @@ -25,6 +31,73 @@ dependencies { | |||
| testImplementation project(':data-prepper-test-common') | |||
| } | |||
|
|
|||
| task copyGeoLite2Files(type: Copy) { | |||
There was a problem hiding this comment.
Rather than use a Copy task, you can use a Download task.
See this example:
data-prepper/release/archives/build.gradle
Lines 77 to 81 in 733e7bc
The download plugin will help:
| into(geoLite2Dir) | ||
|
|
||
| doFirst { | ||
| // Trust all certificates |
There was a problem hiding this comment.
Why do you need to trust all? The GitHub certificate is valid.
For example, a simple download works just fine:
wget https://github.com/maxmind/MaxMind-DB/tree/main/test-data/GeoLite2-City-Test.mmdb
| task copyGeoIP2File(type: Copy) { | ||
|
|
||
| def urls = [ | ||
| 'https://github.com/maxmind/MaxMind-DB/tree/main/test-data/GeoIP2-Enterprise-Test.mmdb' |
There was a problem hiding this comment.
This file is still checked in. Let's remove this too.
|
Raised another PR - 3373 for downloading test mmdb's from maxmind to resources folder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented downlaod maxmind test mmdb files to resource folder
Issues Resolved
GitHub-issue #253
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.