Correctly add compression extensions to the generated S3 sink keys #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f compression is internal, does not utilize. Resolves opensearch-project#3158. Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed and
oeyh
as code owners
dlvenable
changed the title
engechas
approved these changes
Aug 21, 2023
asifsmohammed
approved these changes
Aug 21, 2023
| return new StandardExtensionProvider(codecExtension); | ||
| } | ||
|
|
||
| String extension = compressionOption.getExtension() |
There was a problem hiding this comment.
Will the configured extension be ignored if there is a internal compression?
There was a problem hiding this comment.
Yes, it will be ignored.
With internal compression the file itself is not compressed. Different parts are independently compressed. A user should not try to run it through GZip/Snappy decompression.
With Parquet specifically, the compression is stored as metadata inside the file. And compressed files retain the .parquet extension.
There was a problem hiding this comment.
This test verifies that exact behavior: getExtension_returns_extension_of_codec_when_compression_internal.
There was a problem hiding this comment.
Thanks for the clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports adding the compression extension for keys generated for the S3 sink. This also avoids adding the extension when the codec supports internal compression.
Issues Resolved
Resolves #3158
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.