Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.4] Improvements in the release GitHub Action #3226

Merged
merged 1 commit into from
Aug 23, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,24 @@ on:
workflow_dispatch:
inputs:
release-major-tag:
description: 'Whether to create major tag of docker image or not. This will create a tag such as 2.3 which points to this version.'
description: 'Whether to create major tag of docker image or not. This will create a tag such as 2 which points to this version.'
required: true
type: boolean
release-latest-tag:
description: >
'Whether to create latest tag of docker image or not. This will update the latest tag to point to this version. You should set this when releasing the latest version, but not patches to old versions.'
Whether to create latest tag of docker image or not. This will update the latest tag to point to this version. You should set this when releasing the latest version, but not patches to old versions.
required: true
type: boolean

permissions:
id-token: write
contents: write
issues: write

jobs:
build:
runs-on: ubuntu-latest
timeout-minutes: 30
timeout-minutes: 50

steps:
- name: Set up JDK
Expand Down Expand Up @@ -109,7 +110,7 @@ jobs:

promote:
runs-on: ubuntu-latest
if: success() || failure()
if: ${{ (success() || failure()) && needs.build.result == 'success' }}
needs: [build, validate-docker, validate-archive]
permissions:
contents: write
Expand Down
Loading