Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag failure (dependent on PR Recursive#3198) #3255

Closed
wants to merge 3 commits into from

Conversation

shenkw1
Copy link
Contributor

@shenkw1 shenkw1 commented Aug 25, 2023

Description

When a kv operation causes a runtime exception to be thrown within the processor, the operation is safely aborted without crashing the processor, and the event is tagged with the provided value.

Since this PR is dependent on the restructuring of code done in #3198 , the implementation of this feature is not fully complete. Once the other PR is approved and merged into main, something similar to the two lines of code below can be added into the recursive try/catch block.

LOG.error("Recursive parsing ran into an unexpected error");
recordEvent.getMetadata().addTags(tagOnFailure);

Issues Resolved

Resolves #886

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kat Shen <[email protected]>
@oeyh
Copy link
Collaborator

oeyh commented Sep 25, 2023

Closing this PR as the remaining work has been completed in #3368

@oeyh oeyh closed this Sep 25, 2023
@shenkw1 shenkw1 deleted the tag-failure branch October 15, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential KeyValueProcessor feature: tag_on_failure
2 participants