Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Gradle 8.3; fixes deprecated Gradle behavior #3269

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

dlvenable
Copy link
Member

@dlvenable dlvenable commented Aug 28, 2023

Description

This PR updates the Gradle build to 8.3. This is the first update to any 8.x version so I also had to fix some deprecated behavior.

Issues Resolved

Resolves #3267

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@chenqi0805 chenqi0805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A side question - do we have any semi-automated mechanism on when it is time to upgrade gradle? Not sure if dependbot can cover this.

@dlvenable
Copy link
Member Author

LGTM! A side question - do we have any semi-automated mechanism on when it is time to upgrade gradle? Not sure if dependbot can cover this.

@chenqi0805 , I don't know of a way.

It appears there is a request for this feature in dependabot that has been open for quite a few years.

dependabot/dependabot-core#2223

@dlvenable dlvenable merged commit db10b9e into opensearch-project:main Sep 1, 2023
49 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 1, 2023
Updates to Gradle 8.3, including fixing deprecated behavior. Resolves #3267

Signed-off-by: David Venable <[email protected]>
(cherry picked from commit db10b9e)
dlvenable added a commit that referenced this pull request Sep 7, 2023
Updates to Gradle 8.3, including fixing deprecated behavior. Resolves #3267

Signed-off-by: David Venable <[email protected]>
(cherry picked from commit db10b9e)

Co-authored-by: David Venable <[email protected]>
@dlvenable dlvenable deleted the 3267-gradle-8 branch October 6, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build with Gradle 8
3 participants