Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Maxmind license keys from test URLs #3270

Merged

Conversation

dlvenable
Copy link
Member

Description

Removes Maxmind license keys which should not be present in code.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

@JonahCalvo JonahCalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this David <3

@dlvenable dlvenable merged commit f70ee73 into opensearch-project:main Aug 28, 2023
22 of 24 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 29, 2023
Signed-off-by: David Venable <[email protected]>
(cherry picked from commit f70ee73)
dlvenable added a commit that referenced this pull request Aug 29, 2023
Signed-off-by: David Venable <[email protected]>
(cherry picked from commit f70ee73)

Co-authored-by: David Venable <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants