Adds missing license headers section to the CONTRIBUTING.md file. #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed and
oeyh
as code owners
There was a problem hiding this comment.
Whats the difference between these licenses?
There was a problem hiding this comment.
They are the same license, but the code formatting is different because the different systems take comments different.
I took the approach used in the core project: https://github.com/opensearch-project/.github/blob/main/CONTRIBUTING.md#license-headers
There was a problem hiding this comment.
Thanks, I didn't notice the formatting.
oeyh
approved these changes
Sep 11, 2023
asifsmohammed
approved these changes
Sep 11, 2023
asifsmohammed
pushed a commit
to asifsmohammed/data-prepper
that referenced
this pull request
Sep 27, 2023
…ensearch-project#3292) Signed-off-by: David Venable <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds license headers to the
CONTRIBUTING.mdfile. These were taken and slightly modified from:https://github.com/opensearch-project/.github/blob/main/CONTRIBUTING.md#license-headers
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.