ENH: support pipeline extensions in pipeline config #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
…config Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
chenqi0805
requested review from
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
Signed-off-by: George Chen <[email protected]>
I would not say this is a restriction. This is the design. Using this here is stating that we want it to be the override. |
dlvenable
requested changes
Sep 14, 2023
| @@ -28,6 +30,11 @@ public class PipelinesDataFlowModel { | |||
| @JsonInclude(JsonInclude.Include.NON_NULL) | |||
| private DataPrepperVersion version; | |||
|
|
|||
| @JsonProperty("pipeline_extensions") | |||
There was a problem hiding this comment.
In #2590 this is proposed as pipeline_configurations. I tend to think that we should keep this original name.
There are a couple reasons:
- Extensions are intended for extending Data Prepper. Thus, extensions may need to run before parsing a pipeline configuration.
- The available options in
pipeline_configurationsshould be somewhat different from theextensions. Not everything in extensions should be configurable in the pipeline.
There was a problem hiding this comment.
Will rename this part
| private final Map<String, Object> extensionMap; | ||
|
|
||
| @Inject | ||
| public ExtensionPluginConfigurationResolver(final DataPrepperConfiguration dataPrepperConfiguration, |
There was a problem hiding this comment.
As noted in another comment, we should not tie extensions configurations directly with pipeline configurations. Can we decouple these somewhat?
There was a problem hiding this comment.
Would you mind if I do it in the other PR: #3340. There has been some tweaks on the interface
Signed-off-by: George Chen <[email protected]>
dlvenable
approved these changes
Sep 14, 2023
chenqi0805
deleted the
enh/support-pipeline-extensions-in-pipeline-config
branch
asifsmohammed
pushed a commit
to asifsmohammed/data-prepper
that referenced
this pull request
Sep 27, 2023
…ct#3299) Signed-off-by: George Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support of pipeline_extensions in pipelines configuration file with the following restriction:
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.