Fix issue of skipping new partitions for source coordinator #3319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
graytaylor0
changed the title
Signed-off-by: Taylor Gray <[email protected]>
… for new items for the os source Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
force-pushed
the
FixSkippingOfNewPartitions
branch
from
84127e3
to
8f14472
Compare
engechas
approved these changes
Sep 12, 2023
JonahCalvo
approved these changes
Sep 12, 2023
graytaylor0
changed the title
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
#3319) Fix issue where the source coordinator would skip creating partitions for new items for the os source Signed-off-by: Taylor Gray <[email protected]> --------- Signed-off-by: Taylor Gray <[email protected]> (cherry picked from commit 778e9c7)
asifsmohammed
pushed a commit
that referenced
this pull request
Sep 26, 2023
#3319) (#3383) Fix issue where the source coordinator would skip creating partitions for new items for the os source Signed-off-by: Taylor Gray <[email protected]> --------- Signed-off-by: Taylor Gray <[email protected]> (cherry picked from commit 778e9c7) Co-authored-by: Taylor Gray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a couple of issues related to the OpenSearch source
lastModifiedAttimestamp being tracked in the s3 source global state, this could still happen for the s3 source in some scenariosstopmethod of the os source if it crashes before the OpenSearch service is initializedCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.