Rename os source rate/job_count to interval/count, acquire UNASSIGNED partitions before CLOSED partitions #3327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
graytaylor0
force-pushed
the
OSSourceCleanup
branch
from
f3032a2
to
d4db9f6
Compare
… partitions before CLOSED partitions Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
force-pushed
the
OSSourceCleanup
branch
from
d4db9f6
to
795be99
Compare
dlvenable
requested changes
Sep 15, 2023
|
|
||
| @Min(1) | ||
| @JsonProperty("job_count") | ||
| private int jobCount = 1; | ||
| @JsonProperty("count") |
There was a problem hiding this comment.
Is there some other noun modifier we can use instead of "job"? Count is vague and it is hard to understand what is happening here.
There was a problem hiding this comment.
It really represents the the number of times each index will be processed. Do you have a name suggestion? index_processing_count seems a little verbose
There was a problem hiding this comment.
It might be verbose, but I can understand it. Perhaps index_read_count? Or maybe processing_count to avoid the "per-index" idea.
There was a problem hiding this comment.
It is per index though. I like index_read_count
Signed-off-by: Taylor Gray <[email protected]>
chenqi0805
approved these changes
Sep 15, 2023
dlvenable
approved these changes
Sep 16, 2023
asifsmohammed
pushed a commit
to asifsmohammed/data-prepper
that referenced
this pull request
Sep 27, 2023
… partitions before CLOSED partitions (opensearch-project#3327) * Rename os source rate/job_count to interval/count, acquire UNASSIGNED partitions before CLOSED partitions Signed-off-by: Taylor Gray <[email protected]> * Rename count to index_read_count Signed-off-by: Taylor Gray <[email protected]> --------- Signed-off-by: Taylor Gray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rateandjob_counttointervalandcountreOpenAttime is small, and instead will guarantee that all UNASSIGNED partitions are processed before CLOSED partitionsqueryfrom the OpenSearch source configuration, as it is unused in the codeCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.