Updates Trace Analytics sample appliction to run again #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on updates for dependencies and some corrections from the previous PR which started using Temurin which brought in Ubuntu in the image. Signed-off-by: David Venable <[email protected]>
…an still build Docker images. Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed and
oeyh
as code owners
JonahCalvo
approved these changes
Sep 18, 2023
graytaylor0
approved these changes
Sep 18, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 18, 2023
Get the Trace Analytics sample app running again. This includes version updates for dependencies and some corrections from the previous PR which started using Temurin which brought in Ubuntu in the image. Adds GitHub Actions to verify that the trace-analytics example apps can still build Docker images. Signed-off-by: David Venable <[email protected]> (cherry picked from commit 6e2942d)
dlvenable
added a commit
that referenced
this pull request
Sep 20, 2023
Get the Trace Analytics sample app running again. This includes version updates for dependencies and some corrections from the previous PR which started using Temurin which brought in Ubuntu in the image. Adds GitHub Actions to verify that the trace-analytics example apps can still build Docker images. Signed-off-by: David Venable <[email protected]> (cherry picked from commit 6e2942d) Co-authored-by: David Venable <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overall, this project gets the Trace Analytics sample application running again. I was able to run this sample successfully with these changes.
Specifically:
Dockerfileto useapt-getwhich was needed with Updates trace analytics sample app dependencies #3343.Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.