Add normalize_index flag to normalize invalid dynamic indices #3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
engechas
approved these changes
Nov 11, 2023
dinujoh
approved these changes
Nov 11, 2023
dlvenable
reviewed
Nov 11, 2023
| @@ -100,5 +106,29 @@ private void setupIndexWithRetries(final IndexManager indexManager) throws IOExc | |||
| } | |||
| } | |||
| } | |||
| // Restrictions on index names (https://opensearch.org/docs/1.0/opensearch/rest-api/create-index/#index-naming-restrictions) | |||
| private String normalizeIndex(final String indexName) { | |||
There was a problem hiding this comment.
We should probably also check on the length. It isn't documented, but from looking at the code, I believe it is 255.
There was a problem hiding this comment.
Do you think that's something we can add later? We would have to default to truncating right?
There was a problem hiding this comment.
I think we should add it before we release so that our normalization function remains consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
normalize_indexflag, that defaults to false, to theopensearchsink. this makes it so invalid dynamic indices will be made valid according to these rules (https://opensearch.org/docs/1.0/opensearch/rest-api/create-index/#index-naming-restrictions). Any invalid characters will be removeddynamodb_item_versionto justdocument_version(Related to Alternative metadata naming for version #3630)Issues Resolved
Resolves #3487
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.