Add map_to_list processor #3945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hai Yan <[email protected]>
Signed-off-by: Hai Yan <[email protected]>
Signed-off-by: Hai Yan <[email protected]>
oeyh
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed and
dlvenable
as code owners
|
@oeyh Please add README.md file with documentation and examples. |
dlvenable
requested changes
Jan 11, 2024
| } | ||
|
|
||
| try { | ||
| final Object sourceObject = recordEvent.get(config.getSource(), Object.class); |
There was a problem hiding this comment.
Why can't we combine these two lines into:
final Map<String, Object> sourceObject = recordEvent.get(config.getSource(), Map.class);
| for (final Record<Event> record : records) { | ||
| final Event recordEvent = record.getData(); | ||
|
|
||
| if (Objects.nonNull(config.getMapToListWhen()) && !expressionEvaluator.evaluateConditional(config.getMapToListWhen(), recordEvent)) { |
There was a problem hiding this comment.
Let's use config.getMapToListWhen() != null instead of calling Objects.nonNull.
Signed-off-by: Hai Yan <[email protected]>
4 tasks
Done. Also open this issue for documentation website: opensearch-project/documentation-website#6132 |
kkondaka
reviewed
Jan 11, 2024
Comment on lines
72
to
78
| if (config.getRemoveProcessedFields()) { | ||
| Map<String, Object> modifiedSourceMap = new HashMap<>(); | ||
| for (final Map.Entry<String, Object> entry : sourceMap.entrySet()) { | ||
| if (excludeKeySet.contains(entry.getKey())) { | ||
| modifiedSourceMap.put(entry.getKey(), entry.getValue()); | ||
| } | ||
| } |
There was a problem hiding this comment.
This code can be merged with the code in lines 62-70 like below, right?
Map<String, Object> modifiedSourceMap = new HashMap<>();
for (final Map.Entry<String, Object> entry : sourceMap.entrySet()) {
if (excludeKeySet.contains(entry.getKey())) {
modifiedSourceMap.put(entry.getKey(),
continue;
}
targetList.add(Map.of(
config.getKeyName(), entry.getKey(),
config.getValueName(), entry.getValue()
));
}
There was a problem hiding this comment.
Merged the two for loops.
Signed-off-by: Hai Yan <[email protected]>
kkondaka
approved these changes
Jan 11, 2024
dlvenable
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
map_to_listprocessor.The config options are:
source(required): the source map to perform the operationtarget(required): the target listkey_name: the key name of the field to hold the original key, default is "key"value_name: the key name of the field to hold the original value, default is "value"exclude_keys: the keys in source map that will be excluded from processing, default is empty listremove_processed_fields: default is false; if true, will remove processed fields from source mapmap_to_list_when: used to configure a condition for event processing based on certain property of the incoming event. Default is null (all events will be processed).Issues Resolved
Resolves #3935
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.