Refactor lambda plugin #4643
Merged
Refactor lambda plugin #4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srikanth Govindarajan <[email protected]>
srikanthjg
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
kkondaka
previously approved these changes
Jun 20, 2024
dlvenable
requested changes
Jun 20, 2024
| @@ -3,9 +3,10 @@ | |||
| * SPDX-License-Identifier: Apache-2.0 | |||
| */ | |||
|
|
|||
| package org.opensearch.dataprepper.plugins.sink.lambda.accumlator; | |||
| package org.opensearch.dataprepper.plugins.common.lambda.accumlator; | |||
There was a problem hiding this comment.
Please use the package org.openserach.dataprepper.plugins.lambda. for all classes.
Thus, this would become:
org.opensearch.dataprepper.plugins.lambda.common.accumlator;
There was a problem hiding this comment.
I have followed the same pattern as opensearch plugin. i can make the suggested changes, but just want to make sure the pattern followed in the package is consistent.
There was a problem hiding this comment.
Yes, the pattern I described above should be the preferred one.
org.opensearch.dataprepper.plugins.<plugin>.<anything_for_that_plugin>
| @@ -15,7 +15,7 @@ | |||
| */ | |||
| public class ThresholdCheck { | |||
|
|
|||
| private ThresholdCheck() { | |||
| public ThresholdCheck() { | |||
There was a problem hiding this comment.
You don't need this. These are static methods.
Signed-off-by: Srikanth Govindarajan <[email protected]>
Signed-off-by: Srikanth Govindarajan <[email protected]>
dlvenable
approved these changes
Jun 24, 2024
kkondaka
approved these changes
Jun 25, 2024
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 23, 2024
* Refactor lambda plugin Signed-off-by: Srikanth Govindarajan <[email protected]> * Address comments Signed-off-by: Srikanth Govindarajan <[email protected]> * Address comments 2 Signed-off-by: Srikanth Govindarajan <[email protected]> --------- Signed-off-by: Srikanth Govindarajan <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 23, 2024
* Refactor lambda plugin Signed-off-by: Srikanth Govindarajan <[email protected]> * Address comments Signed-off-by: Srikanth Govindarajan <[email protected]> * Address comments 2 Signed-off-by: Srikanth Govindarajan <[email protected]> --------- Signed-off-by: Srikanth Govindarajan <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 30, 2024
* Refactor lambda plugin Signed-off-by: Srikanth Govindarajan <[email protected]> * Address comments Signed-off-by: Srikanth Govindarajan <[email protected]> * Address comments 2 Signed-off-by: Srikanth Govindarajan <[email protected]> --------- Signed-off-by: Srikanth Govindarajan <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 8, 2024
* Refactor lambda plugin Signed-off-by: Srikanth Govindarajan <[email protected]> * Address comments Signed-off-by: Srikanth Govindarajan <[email protected]> * Address comments 2 Signed-off-by: Srikanth Govindarajan <[email protected]> --------- Signed-off-by: Srikanth Govindarajan <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 12, 2024
* Refactor lambda plugin Signed-off-by: Srikanth Govindarajan <[email protected]> * Address comments Signed-off-by: Srikanth Govindarajan <[email protected]> * Address comments 2 Signed-off-by: Srikanth Govindarajan <[email protected]> --------- Signed-off-by: Srikanth Govindarajan <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 14, 2024
* Refactor lambda plugin Signed-off-by: Srikanth Govindarajan <[email protected]> * Address comments Signed-off-by: Srikanth Govindarajan <[email protected]> * Address comments 2 Signed-off-by: Srikanth Govindarajan <[email protected]> --------- Signed-off-by: Srikanth Govindarajan <[email protected]> Signed-off-by: Srikanth Govindarajan <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor lambda sink changes so as to accomodate and reuse code for lambda as a processor.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.