MAINT: backfill documentation into json description for delete_entries #4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Chen <[email protected]>
chenqi0805
requested review from
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
dlvenable
approved these changes
Jul 12, 2024
| @@ -14,14 +16,18 @@ | |||
|
|
|||
| import java.util.List; | |||
|
|
|||
| @JsonClassDescription("https://opensearch.org/docs/latest/data-prepper/pipelines/configuration/processors/delete-entries/#configuration") | |||
There was a problem hiding this comment.
Remove this. We can auto-generate it later.
oeyh
approved these changes
Jul 12, 2024
chenqi0805
deleted the
maint/add-documentation-in-json-property-description-for-delete_entries-processor
branch
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 23, 2024
opensearch-project#4721) * MAINT: backfill documentation into json description for delete_entries Signed-off-by: George Chen <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 23, 2024
opensearch-project#4721) * MAINT: backfill documentation into json description for delete_entries Signed-off-by: George Chen <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 30, 2024
opensearch-project#4721) * MAINT: backfill documentation into json description for delete_entries Signed-off-by: George Chen <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 8, 2024
opensearch-project#4721) * MAINT: backfill documentation into json description for delete_entries Signed-off-by: George Chen <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 12, 2024
opensearch-project#4721) * MAINT: backfill documentation into json description for delete_entries Signed-off-by: George Chen <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 14, 2024
opensearch-project#4721) * MAINT: backfill documentation into json description for delete_entries Signed-off-by: George Chen <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR serves as the starter for backfill plugin setting config table into @JsonPropertyDescription so that a complete json schema can be generated.
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.