Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed s3 sink config validation #5063

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

kkondaka
Copy link
Collaborator

Description

Fixed s3 sink config validation

Issues Resolved

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • [ X] New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • [X ] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Krishna Kondaka added 2 commits October 14, 2024 21:31
Signed-off-by: Krishna Kondaka <[email protected]>
Signed-off-by: Krishna Kondaka <[email protected]>
@kkondaka kkondaka merged commit 47fdbda into opensearch-project:main Oct 15, 2024
46 of 47 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.10 2.10
# Navigate to the new working tree
cd .worktrees/backport-2.10
# Create a new branch
git switch --create backport/backport-5063-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47fdbda0f7fff077f8725f00f2eb42a8f07816d2
# Push it to GitHub
git push --set-upstream origin backport/backport-5063-to-2.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.10

Then, create a pull request where the base branch is 2.10 and the compare/head branch is backport/backport-5063-to-2.10.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 15, 2024
* Fixed s3 sink config validation

Signed-off-by: Krishna Kondaka <[email protected]>

* Added test cases

Signed-off-by: Krishna Kondaka <[email protected]>

---------

Signed-off-by: Krishna Kondaka <[email protected]>
Co-authored-by: Krishna Kondaka <[email protected]>
(cherry picked from commit 47fdbda)
dlvenable pushed a commit that referenced this pull request Oct 15, 2024
* Fixed s3 sink config validation

Signed-off-by: Krishna Kondaka <[email protected]>

* Added test cases

Signed-off-by: Krishna Kondaka <[email protected]>

---------

Signed-off-by: Krishna Kondaka <[email protected]>
Co-authored-by: Krishna Kondaka <[email protected]>
(cherry picked from commit 47fdbda)

Co-authored-by: Krishna Kondaka <[email protected]>
san81 pushed a commit to san81/data-prepper that referenced this pull request Oct 17, 2024
* Fixed s3 sink config validation

Signed-off-by: Krishna Kondaka <[email protected]>

* Added test cases

Signed-off-by: Krishna Kondaka <[email protected]>

---------

Signed-off-by: Krishna Kondaka <[email protected]>
Co-authored-by: Krishna Kondaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants