ENH: conditional required annotation for schema #5109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
Signed-off-by: George Chen <[email protected]>
chenqi0805
requested review from
sb2k16,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
shenkw1
approved these changes
Oct 28, 2024
san81
reviewed
Oct 28, 2024
| @@ -20,6 +21,16 @@ | |||
| import java.util.Locale; | |||
| import java.time.format.DateTimeFormatter; | |||
|
|
|||
| @ConditionalRequired(value = { | |||
| @ConditionalRequired.IfThenElse( | |||
| ifFulfilled = {@ConditionalRequired.SchemaProperty(field = "match", value = "null")}, | |||
There was a problem hiding this comment.
Nit: Having a static import for @ConditionalRequired.SchemaProperty probably will make this statement more easy to read
san81
reviewed
Oct 28, 2024
| @ConditionalRequired.IfThenElse( | ||
| ifFulfilled = { | ||
| @ConditionalRequired.SchemaProperty(field = "format", value = "null"), | ||
| @ConditionalRequired.SchemaProperty(field = "value_expression", value = "null"), |
There was a problem hiding this comment.
Is there a way to express OR releation when there are more than one condition grouped under ifFulfilled
There was a problem hiding this comment.
For OR relation we have to use separate IfThenElse annotation
Signed-off-by: George Chen <[email protected]>
san81
approved these changes
Oct 28, 2024
oeyh
approved these changes
Oct 28, 2024
sb2k16
reviewed
Oct 28, 2024
|
|
||
| @ConditionalRequired(value = { | ||
| @IfThenElse( |
There was a problem hiding this comment.
Do we need to add a test for this annotation.
| import org.opensearch.dataprepper.model.event.EventKey; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| @ConditionalRequired(value = { | ||
| @IfThenElse( |
There was a problem hiding this comment.
Do we need to add a test for this annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.