Fix enum deserialization for geoip and dissect processors #5114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
sb2k16,
chenqi0805,
engechas,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
sb2k16
previously approved these changes
Oct 25, 2024
Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
force-pushed
the
FixEnumAgain
branch
from
cf9c046
to
7fe97ba
Compare
sb2k16
approved these changes
Oct 25, 2024
chenqi0805
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The geoip and dissect processors contained a
Collection<Enum>and aMap<String, Enum>that the new enum deserializer was getting called for, and it does not deserialize on the types.As a short term fix, add @JsonIgnore annotation the geoip enum getter method, and modify the dissect processor to use Map<String, String> with a custom AssertTrue validation and conversion of the target type from string to enum
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.