Add MySQL DataType handler to transform datatype value #5165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dinu John <[email protected]>
Signed-off-by: Dinu John <[email protected]>
dinujoh
requested review from
sb2k16,
chenqi0805,
engechas,
graytaylor0,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
dinujoh
changed the title
dinujoh
changed the title
Signed-off-by: Dinu John <[email protected]>
Signed-off-by: Dinu John <[email protected]>
Signed-off-by: Dinu John <[email protected]>
chenqi0805
previously approved these changes
Nov 1, 2024
oeyh
reviewed
Nov 4, 2024
...c/main/java/org/opensearch/dataprepper/plugins/source/rds/datatype/impl/JsonTypeHandler.java
Outdated
Show resolved
Hide resolved
| return handleNumericType(columnType, (Number) value); | ||
| } | ||
|
|
||
| private String handleNumericType(final MySQLDataType columnType, final Number value) { |
There was a problem hiding this comment.
Are we converting all numeric types to String type here? For numbers that OpenSearch supports, should we keep them as numbers?
...main/java/org/opensearch/dataprepper/plugins/source/rds/datatype/impl/StringTypeHandler.java
Outdated
Show resolved
Hide resolved
Comment on lines
+25
to
+26
| VARCHAR("varchar", DataCategory.STRING, DataSubCategory.CHAR), | ||
| TINYTEXT("tinytext", DataCategory.STRING, DataSubCategory.BYTES), |
There was a problem hiding this comment.
Wondering what's the difference between CHAR and BYTES sub category. Are they represented differently in binlog events?
There was a problem hiding this comment.
The once tagged with DataSubCategory.BYTES the value is encoded in bytes in binlogs.
There was a problem hiding this comment.
Is VARCHAR encoded in bytes in binlog as well, or not?
There was a problem hiding this comment.
No, CHAR and VARCHAR are not encoded in bytes
Signed-off-by: Dinu John <[email protected]>
oeyh
approved these changes
Nov 4, 2024
chenqi0805
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a DataType handling system to properly transform MySQL data types from binary format to their corresponding string representations. This is essential for both change stream processing and parquet file export processing where data from events may be encoded in bytes.
Some handler implementation are stubbed. Will add follow up PR when they are tested with correct implementation.
Issues Resolved
Contributes to #4561
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.