Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Kafka source to override areAcknowlegementsEnabled #5169

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Fix Kafka source to override areAcknowlegementsEnabled #5169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e44bfbe
Fix Kafka source to override areAcknowlegementsEnabled
kkondaka Nov 3, 2024
7aab647
Added unit test case
kkondaka Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...ka-plugins/src/main/java/org/opensearch/dataprepper/plugins/kafka/source/KafkaSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ public KafkaSource(final KafkaSourceConfig sourceConfig,
this.updateConfig(kafkaClusterConfigSupplier);
}

@Override
public boolean areAcknowledgementsEnabled() {
return sourceConfig.getAcknowledgementsEnabled();
}

@Override
public void start(Buffer<Record<Event>> buffer) {
try {
Expand Down
11 changes: 11 additions & 0 deletions ...lugins/src/test/java/org/opensearch/dataprepper/plugins/kafka/source/KafkaSourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import java.util.Objects;

import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyLong;
import static org.mockito.Mockito.doNothing;
Expand Down Expand Up @@ -130,6 +131,7 @@ void setUp() throws Exception {
when(sourceConfig.getTopics()).thenReturn((List) List.of(topic1, topic2));
when(sourceConfig.getSchemaConfig()).thenReturn(null);
when(sourceConfig.getEncryptionConfig()).thenReturn(encryptionConfig);
when(sourceConfig.getAcknowledgementsEnabled()).thenReturn(false);
when(encryptionConfig.getType()).thenReturn(EncryptionType.NONE);
}

Expand Down Expand Up @@ -163,6 +165,15 @@ void test_kafkaSource_basicFunctionality() {
assertTrue(Objects.nonNull(kafkaSource));
kafkaSource.start(buffer);
assertTrue(Objects.nonNull(kafkaSource.getConsumer()));
assertFalse(kafkaSource.areAcknowledgementsEnabled());
}

@Test
void test_kafkaSource_withAcknowledgements() {
when(sourceConfig.getAcknowledgementsEnabled()).thenReturn(true);
kafkaSource = createObjectUnderTest();
assertTrue(Objects.nonNull(kafkaSource));
assertTrue(kafkaSource.areAcknowledgementsEnabled());
}

@Test
Expand Down
Loading