Add MySQL to OpenSearch Geometry data type transformation #5187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dinu John <[email protected]>
dinujoh
requested review from
sb2k16,
chenqi0805,
engechas,
graytaylor0,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
oeyh
reviewed
Nov 13, 2024
Comment on lines
+33
to
+39
| private static final int GEOMETRY_POINT = 1; | ||
| private static final int GEOMETRY_LINESTRING = 2; | ||
| private static final int GEOMETRY_POLYGON = 3; | ||
| private static final int GEOMETRY_MULTIPOINT = 4; | ||
| private static final int GEOMETRY_MULTILINESTRING = 5; | ||
| private static final int GEOMETRY_MULTIPOLYGON= 6; | ||
| private static final int GEOMETRY_COLLECTION = 7; |
There was a problem hiding this comment.
Are we missing the Geometry type here? It's the singular form of the GeometryCollection type
There was a problem hiding this comment.
No, Geometry type is handled by specific type. Geometry type can have specific type for example POINT type.
oeyh
approved these changes
Nov 13, 2024
chenqi0805
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add MySQL to OpenSearch Geometry data type transformation
Issues Resolved
Contributes to #4561
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.