Refactor lambda code to share code between processor and sink #5196
+451
−519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkondaka
requested review from
sb2k16,
chenqi0805,
engechas,
graytaylor0,
dinujoh,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
srikanthjg
reviewed
Nov 16, 2024
| //lambdaLatencyMetric.record(latency.toMillis(), TimeUnit.MILLISECONDS); | ||
| //totalFlushedEvents += eventCount; | ||
|
|
||
| convertLambdaResponseToEvent(resultRecords, response, flushedBuffer, successHandler); |
There was a problem hiding this comment.
We dont need this for sink and hence should not be in common code.
srikanthjg
reviewed
Nov 16, 2024
| @JsonPropertyDescription("Codec configuration for parsing Lambda responses") | ||
| @JsonProperty("response_codec") | ||
| @Valid | ||
| private PluginModel responseCodecConfig; |
There was a problem hiding this comment.
we dont need this for sink ; should be specific to processor
kkondaka
force-pushed
the
lambda-fixes1
branch
from
f02b3c1
to
39fa6e5
Compare
Signed-off-by: Kondaka <[email protected]>
Signed-off-by: Kondaka <[email protected]>
Signed-off-by: Kondaka <[email protected]>
kkondaka
force-pushed
the
lambda-fixes1
branch
from
39fa6e5
to
36162cb
Compare
Signed-off-by: Kondaka <[email protected]>
Signed-off-by: Kondaka <[email protected]>
Signed-off-by: Kondaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor lambda code to share code between processor and sink
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.