Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user-defined labels on pvcs #591

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

simonstumpf
Copy link
Contributor

@simonstumpf simonstumpf commented Sep 9, 2024

Description

Add support for user-defined labels on PVCs.

Issues Resolved

Closes #554

Check List

  • Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

  • Helm chart version bumped
  • Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@simonstumpf
Copy link
Contributor Author

accidentally deleted #555, sorry for that

@peterzhuamazon
Copy link
Member

Hi @simonstumpf sorry we just merged a feature in #586 which bumped the version again.

Would you mind update your version?

Thanks.

@peterzhuamazon
Copy link
Member

Adding @prudhvigodithi to take a look here.

Thanks.

Signed-off-by: Simon Stumpf <[email protected]>
@simonstumpf
Copy link
Contributor Author

Hi @peterzhuamazon
Sure, no worries. I've updated the files.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems fine for me.
Adding @prudhvigodithi to take a look on this.

Thanks.

@prudhvigodithi
Copy link
Member

Great LGTM thanks @simonstumpf, can you please update the bottom section of the changelog file, here is the example PR.
https://github.com/opensearch-project/helm-charts/pull/589/files.

Signed-off-by: Simon Stumpf <[email protected]>
@simonstumpf
Copy link
Contributor Author

Great LGTM thanks @simonstumpf, can you please update the bottom section of the changelog file, here is the example PR. https://github.com/opensearch-project/helm-charts/pull/589/files.

@prudhvigodithi Added it now, thx

@prudhvigodithi
Copy link
Member

Thanks I have approved the PR, we can merge once the CI checks pass.
Adding @peterzhuamazon.

@prudhvigodithi prudhvigodithi added the backport 1.x Backport to 1.x branch after merging to main label Sep 16, 2024
@peterzhuamazon peterzhuamazon merged commit 77b3e6c into opensearch-project:main Sep 16, 2024
8 checks passed
@peterzhuamazon
Copy link
Member

Thanks @simonstumpf would you mind backport the change to 1.x branch?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x Backport to 1.x branch after merging to main first-time-contributor
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Enhancement][opensearch] Allow user-defined labels on pvcs
3 participants