feat(chart/opensearch): add ability for serviceMonitor basicauth #594
+155
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyenx
requested review from
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
|
Note: We are in the review of an older PR now so will come back to this a little later. |
|
@peterzhuamazon any update here? Thanks! |
|
@peterzhuamazon any update here? |
charts/opensearch/values.yaml
Outdated
| # password: | ||
| # secretName: credentials | ||
| # secretKey: password | ||
| basicAuth: {} |
There was a problem hiding this comment.
Thanks @eyenx can you please some details in the README ? also can basicAuth have one secret with username and password ?
There was a problem hiding this comment.
I will take a look at it tomorrow
There was a problem hiding this comment.
I now added a existingSecret functionality and a way to deliver the username & pw over the helm charts values
Signed-off-by: Toni Tauro <[email protected]>
Signed-off-by: Toni Tauro <[email protected]>
Signed-off-by: Toni Tauro <[email protected]>
eyenx
force-pushed
the
feat/serviceMonitor-with-basic-auth
branch
from
c4b5ba0
to
f3a06ee
Compare
|
Hi @TheAlgo @prudhvigodithi please take another pass before I give an approval. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now there is non possibility to set a
basicAuthconfiguration for theserviceMonitor. This PR adds itCheck List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.