fix: resolve helm lint errors with extraObjects
#607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanidium
requested review from
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
cyanidium
changed the title
helm lint errors with extraObjects
|
I just noticed that this also needs to be applied to the dashboards chart. The change undoes some unneeded whitespace removal from an earlier commit. |
If using `extraObjects`, the generated manifest fails `helm lint` with: ```shell [ERROR] templates/extraManifests.yaml: unable to parse YAML: invalid Yaml document separator: apiVersion: apps/v1 ``` This is a known issue [1] just with the go templates used for helm lint and doesn't apply to the actual template that is applied. The fix [2] is to make the whitespace work for both commands. [1] helm/helm#10149 [2] helm/helm#10149 (comment) Signed-off-by: Martin Rowe <[email protected]>
cyanidium
force-pushed
the
fix/helm-lint
branch
2 times, most recently
from
daaf461
to
31edb1f
Compare
Signed-off-by: Martin Rowe <[email protected]>
cyanidium
force-pushed
the
fix/helm-lint
branch
from
31edb1f
to
5a42a68
Compare
|
Hi @cyanidium could you backport this change to 1.x branch as well? Thanks. |
PR #608 should be the one |
Thanks, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If using
extraObjects, the generated manifest failshelm lintwith:This is a known issue [1] just with the go templates used for helm lint and doesn't apply to the actual template that is applied. The fix [2] is to make the whitespace work for both commands.
[1] helm/helm#10149
[2] helm/helm#10149 (comment)
Issues Resolved
Resolves #606
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.