Skip to content

Commit

Permalink
Fit and Finish Changes for DataStreams and Rollups (#1153)
Browse files Browse the repository at this point in the history
* Fit and Finish Changes for DataStreams and Rollups

Signed-off-by: Sandeep Kumawat <[email protected]>

* Makde changes for Rollup page

Signed-off-by: Sandeep Kumawat <[email protected]>

* Notification page changes

Signed-off-by: Sandeep Kumawat <[email protected]>

* Address PR comments

Signed-off-by: Sandeep Kumawat <[email protected]>

* Review comments

Signed-off-by: Sandeep Kumawat <[email protected]>

* Address offline review comments

Signed-off-by: Sandeep Kumawat <[email protected]>

* This commit includes-

1. Remove padding from view Json Modal of rollup details page
2. Make steps smaller for create rollup page.
3. Remove extra padding from bottom buttons of rollup page

Signed-off-by: Sandeep Kumawat <[email protected]>

* Old UI title changes

Signed-off-by: Sandeep Kumawat <[email protected]>

* make gaps between bottom button small

Signed-off-by: Sandeep Kumawat <[email protected]>

* resolve conflicts

Signed-off-by: Sandeep Kumawat <[email protected]>

---------

Signed-off-by: Sandeep Kumawat <[email protected]>
Co-authored-by: Sandeep Kumawat <[email protected]>
  • Loading branch information
skumawat2025 and Sandeep Kumawat authored Sep 2, 2024
1 parent 8a0ae28 commit a7efceb
Show file tree
Hide file tree
Showing 80 changed files with 2,356 additions and 1,943 deletions.
4 changes: 2 additions & 2 deletions public/components/ContentPanel/ContentPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const ContentPanel: React.SFC<ContentPanelProps> = ({
const isGhost = color === "ghost";
const titleContent = (
<EuiFlexGroup
style={{ ...(noExtraPadding ? { marginTop: 0, marginBottom: 0 } : {}), padding: isGhost || accordion ? undefined : "0px 10px" }}
style={{ ...(noExtraPadding ? { marginTop: 0, marginBottom: 0 } : {}), padding: isGhost || accordion ? undefined : "0px 16px" }}
justifyContent="spaceBetween"
alignItems="flexStart"
>
Expand Down Expand Up @@ -111,7 +111,7 @@ const ContentPanel: React.SFC<ContentPanelProps> = ({
{children ? (
<div
style={{
padding: isGhost ? undefined : "0px 10px",
padding: isGhost ? undefined : "0px 16px",
...bodyStyles,
display: accordion && isAccordionOpen === "closed" ? "none" : undefined,
}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exports[`<ContentPanel /> spec renders the component 1`] = `
>
<div
class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--alignItemsFlexStart euiFlexGroup--justifyContentSpaceBetween euiFlexGroup--directionRow euiFlexGroup--responsive"
style="padding: 0px 10px;"
style="padding: 0px 16px;"
>
<div
class="euiFlexItem"
Expand Down Expand Up @@ -53,7 +53,7 @@ exports[`<ContentPanel /> spec renders the component 1`] = `
class="euiHorizontalRule euiHorizontalRule--full euiHorizontalRule--marginXSmall"
/>
<div
style="padding: 0px 10px;"
style="padding: 0px 16px;"
>
<div>
Testing ContentPanel
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const DisplayItem = (
const { listItem, ...others } = props;
return (
<EuiDescriptionList
compressed={true}
listItems={[
{
...listItem,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ exports[`<DescriptionListHoz /> spec renders the component 1`] = `
class="euiFlexItem"
>
<dl
class="euiDescriptionList euiDescriptionList--row"
class="euiDescriptionList euiDescriptionList--row euiDescriptionList--compressed"
>
<dt
class="euiDescriptionList__title"
Expand Down
14 changes: 8 additions & 6 deletions public/containers/ClearCacheModal/ClearCacheModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,14 @@ export default function ClearCacheModal(props: ClearCacheModalProps) {
)}
</div>
<EuiCallOut color="warning" iconType="warning" hidden={blockedItems.length == 0} size="s">
<p>{blockHint}</p>
<EuiText size="s">
<p>{blockHint}</p>
</EuiText>
<ul style={{ listStyleType: "disc", listStylePosition: "inside" }}>
{blockedItems.map((item) => (
<li key={item}>{item}</li>
<EuiText size="s">
<li key={item}>{item}</li>
</EuiText>
))}
</ul>
</EuiCallOut>
Expand All @@ -217,11 +221,9 @@ export default function ClearCacheModal(props: ClearCacheModalProps) {
<EuiModal onClose={onClose}>
<EuiModalHeader>
<EuiModalHeaderTitle>
{" "}
<EuiText size="s">
{" "}
<h2>Clear cache for {type}</h2>{" "}
</EuiText>{" "}
<h2>Clear cache for {type}</h2>
</EuiText>
</EuiModalHeaderTitle>
</EuiModalHeader>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,14 @@ HTMLCollection [
<div
class="euiModalHeader__title"
>
<div
class="euiText euiText--small"
>
<h2>
Clear cache for
indexes
</h2>
</div>
</div>
</div>
<div
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exports[`<ErrorNotification /> spec renders the component 1`] = `
>
<div
class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--alignItemsFlexStart euiFlexGroup--justifyContentSpaceBetween euiFlexGroup--directionRow euiFlexGroup--responsive"
style="padding: 0px 10px;"
style="padding: 0px 16px;"
>
<div
class="euiFlexItem"
Expand Down
20 changes: 13 additions & 7 deletions public/containers/FlushIndexModal/FlushIndexModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -159,18 +159,20 @@ export default function FlushIndexModal(props: FlushIndexModalProps) {
<EuiModal onClose={onClose}>
<EuiModalHeader>
<EuiModalHeaderTitle data-test-subj="flushModalTitle">
{" "}
<EuiText size="s">
{" "}
<h2>Flush {flushTarget}</h2>{" "}
</EuiText>{" "}
<h2>Flush {flushTarget}</h2>
</EuiText>
</EuiModalHeaderTitle>
</EuiModalHeader>

<EuiModalBody>
<div style={{ lineHeight: 1.5 }}>
{/* we will not display this part if not flushAll and there is no flushable items */}
{flushAll && <p>{flushAllMessage}</p>}
{flushAll && (
<EuiText size="s">
<p>{flushAllMessage}</p>
</EuiText>
)}
{!!unBlockedItems.length && (
<>
<EuiText size="s">
Expand All @@ -187,10 +189,14 @@ export default function FlushIndexModal(props: FlushIndexModalProps) {
)}
<EuiSpacer />
<EuiCallOut data-test-subj="flushBlockedCallout" color="warning" size="s" hidden={!blockedItems.length}>
<p>{blockedItemsMessageTemplate(flushTarget)}</p>
<EuiText size="s">
<p>{blockedItemsMessageTemplate(flushTarget)}</p>
</EuiText>
<ul style={{ listStyleType: "disc", listStylePosition: "inside" }}>
{blockedItems.map((item) => (
<li key={item}>{item}</li>
<EuiText size="s">
<li key={item}>{item}</li>
</EuiText>
))}
</ul>
</EuiCallOut>
Expand Down
Loading

0 comments on commit a7efceb

Please sign in to comment.