Bug fix active option #1042
Merged
Bug fix active option #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamakrishnaChilaka
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90,
eirsep,
r1walz and
vikasvb90
as code owners
RamakrishnaChilaka
force-pushed
the
bug_fix_active_option
branch
from
433b13b
to
35b94cd
Compare
Signed-off-by: Ramakrishna Chilaka <[email protected]>
RamakrishnaChilaka
force-pushed
the
bug_fix_active_option
branch
from
35b94cd
to
91fbaed
Compare
SuZhou-Joe
approved these changes
Apr 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Signed-off-by: Ramakrishna Chilaka <[email protected]> (cherry picked from commit 9a8015a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Apr 18, 2024
(cherry picked from commit 9a8015a) Signed-off-by: Ramakrishna Chilaka <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DataSourcePicker in core expects activeOption prop to be undefined in the first load, so that it can choose a default data source and send it as part of
onSelectedDataSourcescallback function.Issues Resolved
#1041
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.