Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dataVersionFilter support to MDS to enable version decoupling #1080

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

RamakrishnaChilaka
Copy link
Collaborator

Description

Adds changes for version decoupling by passing filter function which utilises manifest file to filter data sources.

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

SuZhou-Joe
SuZhou-Joe previously approved these changes Jul 11, 2024
@SuZhou-Joe
Copy link
Member

A little bit weird why macos always failed.

@SuZhou-Joe SuZhou-Joe merged commit 50c2275 into opensearch-project:main Jul 11, 2024
14 of 18 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1080-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 50c2275589fcfe9427d0db88a9a91eebb3325e12
# Push it to GitHub
git push --set-upstream origin backport/backport-1080-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1080-to-2.x.

RamakrishnaChilaka added a commit to RamakrishnaChilaka/index-management-dashboards-plugin that referenced this pull request Jul 11, 2024
…pensearch-project#1080)

* Adding dataVersionFilter support to MDS to enable version decoupling

Signed-off-by: Ramakrishna Chilaka <[email protected]>

* added check for checking available plugins on a datasource

Signed-off-by: Ramakrishna Chilaka <[email protected]>

---------

Signed-off-by: Ramakrishna Chilaka <[email protected]>
(cherry picked from commit 50c2275)
CaptainDredge pushed a commit to CaptainDredge/index-management-dashboards-plugin that referenced this pull request Jul 12, 2024
…pensearch-project#1080)

* Adding dataVersionFilter support to MDS to enable version decoupling

Signed-off-by: Ramakrishna Chilaka <[email protected]>

* added check for checking available plugins on a datasource

Signed-off-by: Ramakrishna Chilaka <[email protected]>

---------

Signed-off-by: Ramakrishna Chilaka <[email protected]>
RamakrishnaChilaka added a commit to RamakrishnaChilaka/index-management-dashboards-plugin that referenced this pull request Jul 16, 2024
…pensearch-project#1080)

* Adding dataVersionFilter support to MDS to enable version decoupling

Signed-off-by: Ramakrishna Chilaka <[email protected]>

* added check for checking available plugins on a datasource

Signed-off-by: Ramakrishna Chilaka <[email protected]>

---------

Signed-off-by: Ramakrishna Chilaka <[email protected]>
SuZhou-Joe pushed a commit that referenced this pull request Jul 16, 2024
…1080) (#1083)

* Adding dataVersionFilter support to MDS to enable version decoupling



* added check for checking available plugins on a datasource



---------

Signed-off-by: Ramakrishna Chilaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants