Persist dataSourceId across applications under new Nav change #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhat Sharma <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: Prabhat Sharma <[email protected]>
CaptainDredge
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90,
eirsep,
r1walz and
vikasvb90
as code owners
SuZhou-Joe
reviewed
Jul 16, 2024
SuZhou-Joe
reviewed
Jul 16, 2024
added 2 commits
July 17, 2024 21:40
Signed-off-by: Prabhat Sharma <[email protected]>
Signed-off-by: Prabhat Sharma <[email protected]>
SuZhou-Joe
approved these changes
Jul 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
* Persist datasource across Apps Signed-off-by: Prabhat Sharma <[email protected]> * feat: enable passing data source info within ISM Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: Prabhat Sharma <[email protected]> * Fixed duplicate app in navigation Signed-off-by: Prabhat Sharma <[email protected]> * Added description to features Signed-off-by: Prabhat Sharma <[email protected]> --------- Signed-off-by: Prabhat Sharma <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Prabhat Sharma <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit 6216c69) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
added a commit
that referenced
this pull request
Jul 23, 2024
…#1090) * Persist datasource across Apps * feat: enable passing data source info within ISM * Fixed duplicate app in navigation * Added description to features --------- (cherry picked from commit 6216c69) Signed-off-by: Prabhat Sharma <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Prabhat Sharma <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
…#1090) * Persist datasource across Apps * feat: enable passing data source info within ISM * Fixed duplicate app in navigation * Added description to features --------- (cherry picked from commit 6216c69) Signed-off-by: Prabhat Sharma <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Prabhat Sharma <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit cab3758) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
added a commit
that referenced
this pull request
Jul 23, 2024
…#1090) (#1098) * Persist datasource across Apps * feat: enable passing data source info within ISM * Fixed duplicate app in navigation * Added description to features --------- (cherry picked from commit 6216c69) (cherry picked from commit cab3758) Signed-off-by: Prabhat Sharma <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Prabhat Sharma <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change persists dataSourceId across ISM sub applications when new Nav Ux is enabled
Issues Resolved
Related Issue: opensearch-project/OpenSearch-Dashboards#7027
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.