-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update newHeader for Snapshot pages #1105
Conversation
f548d9c
to
a9504c8
Compare
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
a9504c8
to
58cc80a
Compare
@@ -139,30 +144,28 @@ export class CreateSnapshotPolicy extends MDSEnabledComponent<CreateSMPolicyProp | |||
repoError: "", | |||
minCountError: "", | |||
timezoneError: "", | |||
useNewUX: useNewUx, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps move it to a context state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SuZhou-Joe I'm of the opinion that its better to check for feature flag in main.tsx
and pass it as a prop to components, we won't need context since its just a single level prop drilling. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am just thinking we are copy
const uiSettings = getUISettings();
const useNewUx = uiSettings.get("home:useNewHomePage");
in multiple place, maybe we can consider to move that to a util or somewhere.
The screenshot looks good to me. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1105-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c486b61345ee3411a6fa9f162180d807d5d9e8ea
# Push it to GitHub
git push --set-upstream origin backport/backport-1105-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x Then, create a pull request where the |
* PoC for ism Signed-off-by: Sandeep Kumawat <[email protected]> * Update newHeader for snapshot policies page Signed-off-by: Sandeep Kumawat <[email protected]> * new page header update for index snapshot and repository pages Signed-off-by: Sandeep Kumawat <[email protected]> * triger gh workflows Signed-off-by: Sandeep Kumawat <[email protected]> --------- Signed-off-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]>
* PoC for ism Signed-off-by: Sandeep Kumawat <[email protected]> * Update newHeader for snapshot policies page Signed-off-by: Sandeep Kumawat <[email protected]> * new page header update for index snapshot and repository pages Signed-off-by: Sandeep Kumawat <[email protected]> * triger gh workflows Signed-off-by: Sandeep Kumawat <[email protected]> --------- Signed-off-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]>
* PoC for ism * Update newHeader for snapshot policies page * new page header update for index snapshot and repository pages * triger gh workflows --------- Signed-off-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]>
Description
This PR tries to update the new Header for snapshot pages
Issues Resolved
[List any issues this PR will resolve]
Snapshot policy (when
newHomePage
is off)Snapshot policy (when
newHomePage
is on)Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.