Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation]feat: reorder features and rename title and description #1106

Merged

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Aug 13, 2024

Description

Change the title / description / categories of the features to comply with new design in 2.17.

Before

image

After

image

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@SuZhou-Joe
Copy link
Member Author

The macos-latest failure is not irrelevant to the code changes.

Copy link
Contributor

@AWSHurneyt AWSHurneyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as it looks like the failing unit test is a pre-existing issue.
https://github.com/opensearch-project/index-management-dashboards-plugin/pull/1099/checks

@SuZhou-Joe SuZhou-Joe merged commit c8cea51 into opensearch-project:main Aug 14, 2024
11 of 13 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 14, 2024
Signed-off-by: SuZhou-Joe <[email protected]>
(cherry picked from commit c8cea51)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 15, 2024
(cherry picked from commit c8cea51)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants