Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rollup jobs and transform jobs title with total numbers of jobs #1164

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

skumawat2025
Copy link
Contributor

@skumawat2025 skumawat2025 commented Sep 3, 2024

Description

This PR achieves 3 things.

  1. Show number of rollup jobs in the title of rollup jobs
  2. Show number of transform jobs in the title of transform jobs
  3. Removes plus in circle icon in snapshot pages buttons introduced by [Look & Feel] Consistency and Density Changes for Snapshot Management #1148 as this is not required according to guidelines.

Before

Rollup Jobs
image

Transform Jobs
image

After

Rollup Jobs
image

Transform Jobs
image

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Sandeep Kumawat added 2 commits September 3, 2024 09:03
@tandonks
Copy link
Contributor

tandonks commented Sep 3, 2024

Looks good

@astute-decipher
Copy link
Contributor

LGTM

@SuZhou-Joe SuZhou-Joe merged commit 163ad4e into opensearch-project:main Sep 3, 2024
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 3, 2024
#1164)

* Add number of rollup jobs in the rollup jobs title

Signed-off-by: Sandeep Kumawat <[email protected]>

* Transform numbers in title

Signed-off-by: Sandeep Kumawat <[email protected]>

---------

Signed-off-by: Sandeep Kumawat <[email protected]>
Co-authored-by: Sandeep Kumawat <[email protected]>
(cherry picked from commit 163ad4e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Sep 3, 2024
#1164) (#1167)

* Add number of rollup jobs in the rollup jobs title



* Transform numbers in title



---------



(cherry picked from commit 163ad4e)

Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sandeep Kumawat <[email protected]>
@skumawat2025 skumawat2025 deleted the bug-fixes-rollups branch September 4, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants