adding cancel button to change policy

[kohinoor98]

Description

Added Cancel button to ChangePolicy.tsx

Issues Resolved

#840

Check List

• Commits are signed per the DCO using --signoff
• Test the Cancel button in Change Policy page

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[AWSHurneyt]

@kohinoor98 looks like some snapshot unit tests failed. Could you run yarn run test:jest -u? That will update the snapshots, and should allow the unit tests to pass.

[kohinoor98]

Hi @AWSHurneyt

The current test case that is failing is addressed in this PR #918. The other test case that is failing should be handled by the changes made to ChangePolicy.test.tsx.snap.

Please advice on next steps.

Thanks,
KC

[AWSHurneyt]

@kohinoor98 Looks like there's still a unit test failing in the ChangePolicy.test.tsx.
https://github.com/opensearch-project/index-management-dashboards-plugin/actions/runs/6805289930/job/18504495378?pr=919#step:10:860

I see in the commits tab for this PR that changes from the main branch were merged into the dev branch for this PR after the snapshot was updated. Could you try running yarn run test:jest -u again? If that doesn't resolve the failing test, it may need deeper investigation.

[codecov]

Codecov Report

Merging #919 (96b5c0b) into main (461f563) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #919   +/-   ##
=======================================
  Coverage   63.36%   63.37%           
=======================================
  Files         341      341           
  Lines       11553    11554    +1     
  Branches     2243     2243           
=======================================
+ Hits         7321     7322    +1     
  Misses       3658     3658           
  Partials      574      574           

see 1 file with indirect coverage changes

[kohinoor98]

Hi @AWSHurneyt

I have updated the PR with the latest code from yarn run test:jest -u for the cancel button.

I tested snapshots_spec.js on cypress and it kept failing in one to three of the test cases for some reason or the other over 10 runs.

I am guessing @bowenlan-amzn noticed the same and created #925 for the same.

Thanks,
KC