Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the notification_setting test by giving a obedient slack url #961

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Jan 10, 2024

Description

Fix the notification_setting test by giving a obedient slack url
regression from opensearch-project/notifications#814

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.37%. Comparing base (be76a29) to head (cee482a).
Report is 52 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #961    +/-   ##
========================================
  Coverage   63.37%   63.37%            
========================================
  Files         341      341            
  Lines       11554    11554            
  Branches     2243     2112   -131     
========================================
  Hits         7322     7322            
  Misses       3658     3658            
  Partials      574      574            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bowenlan-amzn bowenlan-amzn merged commit e855cb5 into opensearch-project:main Jan 10, 2024
12 checks passed
@bowenlan-amzn bowenlan-amzn deleted the fix-slack-url branch January 10, 2024 17:36
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-961-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e855cb5f9d8140c230e18bfc765096cfa0c7b8ce
# Push it to GitHub
git push --set-upstream origin backport/backport-961-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-961-to-2.x.

bowenlan-amzn added a commit to bowenlan-amzn/index-management-dashboards-plugin that referenced this pull request Jan 18, 2024
bowenlan-amzn added a commit to bowenlan-amzn/index-management-dashboards-plugin that referenced this pull request Jan 18, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 23, 2024
(cherry picked from commit e855cb5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Aug 23, 2024
… (#1147)

(cherry picked from commit e855cb5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants