Call listner.onFailure when lock creation failed #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heemin32
requested review from
joshpalis,
saratvemulapalli,
dbwiddis,
kaituo and
vibrantvarun
as code owners
kaituo
approved these changes
Jul 31, 2023
Signed-off-by: Heemin Kim <[email protected]>
|
@heemin32 could you rebase your changes? |
Already did. |
Codecov Report
@@ Coverage Diff @@
## main #435 +/- ##
=========================================
Coverage 29.19% 29.19%
Complexity 98 98
=========================================
Files 22 22
Lines 1185 1185
Branches 109 109
=========================================
Hits 346 346
Misses 818 818
Partials 21 21 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit d2e0ac0)
vibrantvarun
pushed a commit
that referenced
this pull request
Aug 1, 2023
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit d2e0ac0) Co-authored-by: Heemin Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When lockId is too long, it silently call
onResponseof listener withnull. In such case, we don't know if lock acquire is failed because the lock is being hold by other processor, or lock creation itself is failed. We should callonFailurewithexceptionso that caller can handle such case accordingly.Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.