Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use to use the build CI image in ci.yml #534

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Oct 24, 2023

Description

Use to use the build CI image in ci.yml.

Issues Resolved

Part of opensearch-project/opensearch-build#3966
Closes #524

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi
Copy link
Member Author

Hey @peterzhuamazon can you please take a look at this PR?
I assume as suggested in meta issue need to only the build and test workflows and not the bwc test workflows, also did not use the option options: --user root as there are no packages that needs to be installed for job-scheduler.
Thank you

Adding @joshpalis @minalsha @bbarani

Signed-off-by: Prudhvi Godithi <[email protected]>
@prudhvigodithi
Copy link
Member Author

Looks like we need the options: --user root to allow the repo checkout inside the container, added back.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #534 (907f049) into main (72098a3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #534   +/-   ##
=========================================
  Coverage     29.17%   29.17%           
  Complexity       98       98           
=========================================
  Files            22       22           
  Lines          1186     1186           
  Branches        109      109           
=========================================
  Hits            346      346           
  Misses          819      819           
  Partials         21       21           

@prudhvigodithi
Copy link
Member Author

Hey @joshpalis can you please take a look at the failed tests ? are they flaky ?

@joshpalis
Copy link
Member

@prudhvigodithi , yes this is a flaky test, which has been identified in the handoff document.

org.opensearch.jobscheduler.sampleextension.SampleJobRunnerIT > testJobUpdateWithRescheduleJob FAILED
    java.lang.AssertionError: expected:<1> but was:<0>
        at __randomizedtesting.SeedInfo.seed([14A61049E22DA007:C548E907BD31869D]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:647)
        at org.junit.Assert.assertEquals(Assert.java:633)
        at org.opensearch.jobscheduler.sampleextension.SampleJobRunnerIT.testJobUpdateWithRescheduleJob(SampleJobRunnerIT.java:81)
REPRODUCE WITH: ./gradlew ':opensearch-job-scheduler-sample-extension:integTest' --tests "org.opensearch.jobscheduler.sampleextension.SampleJobRunnerIT.testJobUpdateWithRescheduleJob" -Dtests.seed=14A61049E22DA007 -Dtests.security.manager=false -Dtests.locale=hr-HR -Dtests.timezone=America/Indiana/Indianapolis -Druntime.java=11

I'll re-run the failed checks

@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/job-scheduler/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/job-scheduler/backport-2.x
# Create a new branch
git switch --create backport-534-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3f20f053746af6c618f85a51cb84a33516e15c98
# Push it to GitHub
git push --set-upstream origin backport-534-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/job-scheduler/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport-534-to-2.x.

@peterzhuamazon
Copy link
Member

Hi @prudhvigodithi could you help backport this to 2.x?
Thanks.

@prudhvigodithi
Copy link
Member Author

I have created a backport PR #535
@peterzhuamazon @joshpalis @cwperks please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Campaign] Ensure Github workflow runs on docker image used by Production Distribution Build
4 participants