-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use to use the build CI image in ci.yml #534
Conversation
Hey @peterzhuamazon can you please take a look at this PR? Adding @joshpalis @minalsha @bbarani |
Signed-off-by: Prudhvi Godithi <[email protected]>
Looks like we need the |
Codecov Report
@@ Coverage Diff @@
## main #534 +/- ##
=========================================
Coverage 29.17% 29.17%
Complexity 98 98
=========================================
Files 22 22
Lines 1186 1186
Branches 109 109
=========================================
Hits 346 346
Misses 819 819
Partials 21 21 |
Hey @joshpalis can you please take a look at the failed tests ? are they flaky ? |
@prudhvigodithi , yes this is a flaky test, which has been identified in the handoff document.
I'll re-run the failed checks |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/job-scheduler/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/job-scheduler/backport-2.x
# Create a new branch
git switch --create backport-534-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3f20f053746af6c618f85a51cb84a33516e15c98
# Push it to GitHub
git push --set-upstream origin backport-534-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/job-scheduler/backport-2.x Then, create a pull request where the |
Hi @prudhvigodithi could you help backport this to 2.x? |
I have created a backport PR #535 |
Description
Use to use the build CI image in ci.yml.
Issues Resolved
Part of opensearch-project/opensearch-build#3966
Closes #524
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.