Changes to publish jar to maven #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kannan R <[email protected]>
kannangce
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas and
0ctopus13prime
as code owners
5 tasks
|
Seems like this doesn't required change-log as suggested in the contribution guide. So this requires adding of |
Vikasht34
approved these changes
Feb 6, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
Signed-off-by: Kannan R <[email protected]> (cherry picked from commit 91fcd86)
jmazanec15
pushed a commit
that referenced
this pull request
Feb 6, 2025
Signed-off-by: Kannan R <[email protected]> (cherry picked from commit 91fcd86) Signed-off-by: John Mazanec <[email protected]>
jmazanec15
pushed a commit
that referenced
this pull request
Feb 6, 2025
(cherry picked from commit 91fcd86) Signed-off-by: Kannan R <[email protected]> Signed-off-by: John Mazanec <[email protected]> Co-authored-by: Kannan Ramamoorthy <[email protected]>
|
If I understood it correctly,
Questions based on my understanding,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to publish the jar of knn plugin to maven.
Related Issues
Resolves #1351
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Testing:
Since it is a call to an existing gradle task. I couldn't exactly test it.
But I'm to run the equivalent task
publishNebulaPublicationToMavenLocaland use the locally published jar from my another project.