Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset to max page when current page overflow #323

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Apr 28, 2024

Description

The PR is for fixing page always stay empty page when jump to no models page. This error always happens in below flow:

  1. User visit deployed models list and total pages are 2.
  2. User jump to 2 page, but the deployed models changed and total pages become 1.
  3. Then the page will always stay empty page like below image
image After this PR, the current page will reset to max page and resend the request. It will jump to page 1 in above cases.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@wanglam wanglam marked this pull request as ready for review April 28, 2024 03:14
@wanglam wanglam merged commit daacbc9 into opensearch-project:main Apr 28, 2024
8 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 28, 2024
Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit daacbc9)
wanglam added a commit that referenced this pull request Apr 28, 2024
Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit daacbc9)

Co-authored-by: Lin Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants