[Backport 2.x] Undeploy models with no WorkerNodes #3447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* undeploy models with no WorkerNodes This commit aims to undeploy modelIds that have no nodes associated to them so as to keep the intention of undeploy truthful. Signed-off-by: Brian Flores <[email protected]> # Conflicts: # plugin/src/main/java/org/opensearch/ml/action/undeploy/TransportUndeployModelsAction.java * Exit early when no nodes service the model Now when entering this method its guaranteed to write to index first before sending back the MLUndeploy response. And will also send back a exception if the write back fails Signed-off-by: Brian Flores <[email protected]> * add UTs for undeploy stale model index fix Added UTs for the 2 scenarios 1. Check that the bulk operation occured when no nodes are returned from the Undeploy response is , 2. Check that the bulk operation did not occur when there are nodes that have found the model within their cache. Signed-off-by: Brian Flores <[email protected]> * update code change with comment explaining the change Signed-off-by: Brian Flores <[email protected]> * add context stash/restore to write operation Signed-off-by: Brian Flores <[email protected]> * Apply spotless Signed-off-by: Brian Flores <[email protected]> * Add better logging to write request Signed-off-by: Brian Flores <[email protected]> * wrap exception into 5xx Signed-off-by: Brian Flores <[email protected]> * adapts undeploy code change to multi-tenancy feature Signed-off-by: Brian Flores <[email protected]> * applies spotless Signed-off-by: Brian Flores <[email protected]> --------- Signed-off-by: Brian Flores <[email protected]> (cherry picked from commit 18bcaae)
opensearch-trigger-bot
bot
requested review from
b4sjoo,
dhrubo-os,
mingshl,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
mingshl
approved these changes
Jan 28, 2025
Zhangxunmt
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 18bcaae from #3380