Run the Get Connector request in a stashed threadcontext #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
b4sjoo,
dhrubo-os,
mingshl,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
cwperks
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
cwperks
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
dhrubo-os
reviewed
Feb 3, 2025
Signed-off-by: Craig Perkins <[email protected]>
cwperks
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
cwperks
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
dhrubo-os
approved these changes
Feb 3, 2025
cwperks
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
b4sjoo
approved these changes
Feb 3, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
* Run the Get Connector request in a stashed threadcontext Signed-off-by: Craig Perkins <[email protected]> * Add restore context Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 09bf858)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
* Run the Get Connector request in a stashed threadcontext Signed-off-by: Craig Perkins <[email protected]> * Add restore context Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 09bf858)
dhrubo-os
pushed a commit
that referenced
this pull request
Feb 3, 2025
* Run the Get Connector request in a stashed threadcontext Signed-off-by: Craig Perkins <[email protected]> * Add restore context Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 09bf858) Co-authored-by: Craig Perkins <[email protected]>
dhrubo-os
pushed a commit
that referenced
this pull request
Feb 3, 2025
* Run the Get Connector request in a stashed threadcontext Signed-off-by: Craig Perkins <[email protected]> * Add restore context Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 09bf858) Co-authored-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes CI issues seen in the skills repo when testing with security.
ref: https://github.com/opensearch-project/skills/actions/runs/13076372692/job/36489480535
This PR surrounds the call to the
.plugins-ml-connectorindex in a stashed context to ensure the action runs in a trusted system context.The security plugin has logic to scrub results when searching on system indices or getting individual documents for regular users. Plugins must surround calls to system indices to run in the trusted system context.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.